fix: open browser and copy code for github copilot device oauth flow by sheikhlimon · Pull Request #7577 · block/goose

sheikhlimon · 2026-02-27T18:19:45Z

Summary

Relates to #6957

This PR updates GitHub Copilot's OAuth device code flow to show the code in the UI instead of silently copying it to the clipboard, addressing the UX concern raised in the PR review.

Changes:

Added DeviceCodeModal component with code display and auto-polling for completion
Added discriminated union response types to the OAuth endpoint to keep it compatible with other providers
Added /config/providers/{name}/oauth/completion endpoint for non-blocking completion checks
Updated backend to return device code info immediately and poll for completion
Removed arboard dependency (no longer silently copying to clipboard)

Type of Change

AI Assistance

This PR was created or reviewed with AI assistance

Testing

Added 3 serialization tests for DeviceCodeData struct

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

…rowser-clipboard Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4209eb8fd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T18:23:09Z

crates/goose/src/providers/githubcopilot.rs

+            if clipboard.set_text(code).is_ok() {
+                tracing::info!("GitHub Copilot code copied to clipboard: {}", code);


Handle clipboard write failures in Copilot device login

This logic only falls back when Clipboard::new() fails, but if clipboard initialization succeeds and set_text fails (e.g., Wayland/X11 clipboard permission/runtime issues), no fallback path exposes the device code except println!, which is not visible in the desktop flow this change is trying to fix. In that case users can still get stuck at sign-in because they have a browser window but no code to enter.

Useful? React with 👍 / 👎.

jamadeo

This is a clever way around the issue, but I'm not sure I'd want goose writing directly to my clipboard.

What would it take to properly show the code in the desktop UI?

jamadeo · 2026-03-09T16:16:16Z

crates/goose/src/providers/githubcopilot.rs

+        let code = device_code_info.user_code.as_str();
+
+        if let Ok(mut clipboard) = arboard::Clipboard::new() {
+            if clipboard.set_text(code).is_ok() {


We should avoid writing to the clipboard like this without an explicit action -- the user might have something there they don't want overwritten. Also, I'm not sure the user will know that his code is in their clipboard when the browser opens.

It's more work, but I would suggest looking into modifying the existing /config/providers/{provider}/oauth flow to allow rendering a code in the UI element.

Thanks for pointing that out - the clipboard concern makes sense

sheikhlimon · 2026-03-10T01:37:46Z

This is a clever way around the issue, but I'm not sure I'd want goose writing directly to my clipboard.

What would it take to properly show the code in the desktop UI?

From what I understand, this might involve two changes:

Updating the /config/providers/{provider}/oauth flow to return the device code so the desktop UI can render it.
Adding a UI element to display the code with an explicit copy option.

That way the clipboard write could be removed, since the user would be able to copy it themselves.

Let me know if that sounds roughly like the direction you had in mind.

jamadeo · 2026-03-10T19:27:45Z

@sheikhlimon yes that sounds exactly right! For the oauth handler, however we change it will still need to be compatible with the other providers using it, but this is definitely the way to go.

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

…rowser open Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

sheikhlimon · 2026-03-20T14:49:49Z

@jamadeo I tried implementing the approach we discussed and got close, but I’m running into some limitations and can’t get the final flow to work reliably.

I don’t think I’ll be able to complete this PR properly, so it’s probably best to close it rather than leave it half-working. Happy for someone else to pick it up if needed.

Also, #8019 covers what I initially aimed for and does a better job in terms of UX.

sheikhlimon added 2 commits February 27, 2026 21:17

fix: open browser and copy code for github copilot device oauth flow

7fd3dea

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix/githubcopilot-b…

d4209eb

…rowser-clipboard Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

jamadeo self-assigned this Mar 6, 2026

jamadeo requested changes Mar 9, 2026

View reviewed changes

sheikhlimon added 10 commits March 13, 2026 05:43

add oauth response types for device code flow support

96f4489

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

add oauth response data enum and update provider trait

15b62e7

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

update chatgpt codex to return oauth completed response

398a072

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

update github copilot to return device code and remove clipboard

f0c7f9a

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

remove unused arboard dependency

fd7ecb4

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

update cargo lock after removing arboard

e03f890

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

fix duplicate serde import in base.rs

cf0e6fb

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

add response body to oauth endpoint utoipa spec

b6697b8

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

add oauth response types to openapi schema

81aa8b6

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

update oauth setup to handle device code response

dc5fcf3

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

sheikhlimon marked this pull request as draft March 13, 2026 01:12

sheikhlimon added 12 commits March 13, 2026 07:44

add device code modal component for github copilot

7f3cd29

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

merge upstream main

7db3e10

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

extract github copilot setup to separate file

be4e6ff

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

fmt

64d498c

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

add oauth response data serialization tests

2f2588a

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

fix oauth response data to use struct variants

32fb2f1

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

handle device code response in cli oauth configuration

b2b5873

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

handle device code response in settings provider modal

3aa286e

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

avoid calling refresh_api_info in configure_oauth to prevent double b…

2b07c72

…rowser open Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

prevent double browser open in device code modal

363016a

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

use project dialog component and remove redundant browser button

f1f61a1

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

fmt

95c2837

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

sheikhlimon added 4 commits March 14, 2026 20:11

fix: use dedicated completion check endpoint for OAuth polling

3ffde1b

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

fmt

94507ad

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

use setInterval pattern for OAuth polling

7c9f107

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

fix: add polling logging and tracing for OAuth completion debugging

b8ad58f

Signed-off-by: sheikhlimon <sheikhlimon404@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: open browser and copy code for github copilot device oauth flow#7577

fix: open browser and copy code for github copilot device oauth flow#7577
sheikhlimon wants to merge 28 commits intoblock:mainfrom
sheikhlimon:fix/githubcopilot-browser-clipboard

sheikhlimon commented Feb 27, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

jamadeo left a comment

Uh oh!

jamadeo Mar 9, 2026

Uh oh!

sheikhlimon Mar 10, 2026

Uh oh!

sheikhlimon commented Mar 10, 2026

Uh oh!

jamadeo commented Mar 10, 2026

Uh oh!

sheikhlimon commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if clipboard.set_text(code).is_ok() {
		tracing::info!("GitHub Copilot code copied to clipboard: {}", code);

Conversation

sheikhlimon commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes:

Type of Change

AI Assistance

Testing

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo left a comment

Choose a reason for hiding this comment

Uh oh!

jamadeo Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

sheikhlimon Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

sheikhlimon commented Mar 10, 2026

Uh oh!

jamadeo commented Mar 10, 2026

Uh oh!

sheikhlimon commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sheikhlimon commented Feb 27, 2026 •

edited

Loading